[TEST] - Test unit - Fix failing UI unit test 4.15 branch by utchoang · Pull Request #5219 · apache/cloudstack

utchoang · 2021-07-20T00:48:09Z

Description

Related #5212

Types of changes

Breaking change (fix or feature that would cause existing functionality to change)
New feature (non-breaking change which adds functionality)
Bug fix (non-breaking change which fixes an issue)
Enhancement (improves an existing feature and functionality)
Cleanup (Code refactoring and cleanup, that may add test cases)

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Major
Minor

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

utchoang · 2021-07-26T04:41:19Z

@blueorangutan ui

blueorangutan · 2021-07-26T04:42:04Z

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-26T04:47:38Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5219 (SL-JID-421)

yadvr · 2021-07-27T06:05:47Z

I've checked the code, but tests are passing per Travis:

> cloudstack-ui@1.0.0 lint /home/travis/build/apache/cloudstack/ui
> vue-cli-service lint
 DONE  No lint errors found!
> cloudstack-ui@1.0.0 test:unit /home/travis/build/apache/cloudstack/ui
> vue-cli-service test:unit
Browserslist: caniuse-lite is outdated. Please run:
npx browserslist@latest --update-db
[vue-jest]: Less are not currently compiled by vue-jest
 PASS  tests/unit/views/AutogenView.spec.js (21.07s)
 PASS  tests/unit/views/compute/MigrateWizard.spec.js
 PASS  tests/unit/components/widgets/Status.spec.js
 PASS  tests/unit/components/view/ActionButton.spec.js
=============================== Coverage summary ===============================
Statements   : 4.92% ( 759/15419 )
Branches     : 6% ( 470/7834 )
Functions    : 2.69% ( 136/5063 )
Lines        : 4.91% ( 753/15328 )
================================================================================
Test Suites: 4 passed, 4 total
Tests:       134 passed, 134 total
Snapshots:   0 total
Time:        77.768s
Ran all test suites.

weizhouapache

tested with latest 4.15 branch ok.

prior:

~/git/cloudstack/ui ((HEAD detached from apache/4.15))# npm run test:unit

=============================== Coverage summary ===============================
Statements   : 4.7% ( 725/15424 )
Branches     : 5.76% ( 451/7833 )
Functions    : 2.59% ( 131/5067 )
Lines        : 4.7% ( 721/15333 )
================================================================================
Test Suites: 3 failed, 1 passed, 4 total
Tests:       29 failed, 105 passed, 134 total
Snapshots:   0 total
Time:        33.95s
Ran all test suites.

with this pr

=============================== Coverage summary ===============================
Statements   : 4.92% ( 759/15425 )
Branches     : 6.03% ( 472/7833 )
Functions    : 2.68% ( 136/5067 )
Lines        : 4.91% ( 753/15334 )
================================================================================

Test Suites: 1 failed, 3 passed, 4 total
Tests:       2 failed, 132 passed, 134 total
Snapshots:   0 total
Time:        34.977s
Ran all test suites.

ui/src/utils/plugins.js

Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>

davidjumani · 2021-07-29T04:10:10Z

@blueorangutan ui

blueorangutan · 2021-07-29T04:11:03Z

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-29T04:15:21Z

UI build: ✖️
(SL-JID-443)

ui/src/utils/plugins.js

…yncJob have jobstatus = 1

utchoang · 2021-07-29T06:44:00Z

@blueorangutan ui

blueorangutan · 2021-07-29T06:45:03Z

@utchoang a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-29T06:49:20Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5219 (SL-JID-444)

ui/src/utils/plugins.js

davidjumani · 2021-07-30T07:04:14Z

@blueorangutan ui

blueorangutan · 2021-07-30T07:05:03Z

@davidjumani a Jenkins job has been kicked to build UI QA env. I'll keep you posted as I make progress.

blueorangutan · 2021-07-30T07:09:40Z

UI build: ✔️
Live QA URL: http://qa.cloudstack.cloud:8080/client/pr/5219 (SL-JID-449)

davidjumani · 2021-07-30T07:28:37Z

 PASS  tests/unit/components/view/ActionButton.spec.js
 PASS  tests/unit/components/widgets/Status.spec.js
 PASS  tests/unit/views/compute/MigrateWizard.spec.js
 PASS  tests/unit/views/AutogenView.spec.js (9.027s)

=============================== Coverage summary ===============================
Statements   : 4.91% ( 760/15477 )
Branches     : 5.99% ( 470/7850 )
Functions    : 2.68% ( 136/5083 )
Lines        : 4.9% ( 754/15386 )
================================================================================

Test Suites: 4 passed, 4 total
Tests:       134 passed, 134 total
Snapshots:   0 total
Time:        17.228s
Ran all test suites.

davidjumani · 2021-07-30T08:30:47Z

@utchoang Can you merge this into main and fix failures on main? Thanks

yadvr · 2021-07-30T09:31:04Z

@utchoang I've forward merged the conflicts on main, any new changes/fixes should be done in the other PR - #5220

fix error test unit on MigrateWizard

c10ec22

utchoang changed the title ~~[TEST] Test unit - Fix failing UI unit test 4.15 branch~~ [WIP] - Test unit - Fix failing UI unit test 4.15 branch Jul 20, 2021

fix error test unit on AutogenView, ActionButton

c9040aa

utchoang changed the title ~~[WIP] - Test unit - Fix failing UI unit test 4.15 branch~~ [TEST] - Test unit - Fix failing UI unit test 4.15 branch Jul 20, 2021

apache deleted a comment from blueorangutan Jul 20, 2021

utchoang added 3 commits July 20, 2021 10:16

fix error lint

af9a511

Merge branch '4.15' into feature/test-unit-4.15

9b5881c

fix error pollJob originalPage.starWith undefined

d42f306

apache deleted a comment from blueorangutan Jul 26, 2021

yadvr added this to the 4.15.2.0 milestone Jul 27, 2021

yadvr requested review from davidjumani, nvazquez, sureshanaparti and weizhouapache July 27, 2021 06:05

weizhouapache approved these changes Jul 27, 2021

View reviewed changes

shwstppr approved these changes Jul 27, 2021

View reviewed changes

nvazquez closed this Jul 27, 2021

nvazquez reopened this Jul 27, 2021

nvazquez approved these changes Jul 27, 2021

View reviewed changes

davidjumani reviewed Jul 28, 2021

View reviewed changes

ui/src/utils/plugins.js Outdated Show resolved Hide resolved

davidjumani reviewed Jul 28, 2021

View reviewed changes

ui/src/utils/plugins.js Outdated Show resolved Hide resolved

Hoang Nguyen and others added 2 commits July 29, 2021 07:28

Update ui/src/utils/plugins.js

3a16d95

Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>

Update ui/src/utils/plugins.js

88c5386

Co-authored-by: davidjumani <dj.davidjumani1994@gmail.com>

davidjumani reviewed Jul 29, 2021

View reviewed changes

ui/src/utils/plugins.js Show resolved Hide resolved

uses a substitution variable if the originalPage is null with queryAs…

1276c69

…yncJob have jobstatus = 1

davidjumani approved these changes Jul 29, 2021

View reviewed changes

davidjumani reviewed Jul 30, 2021

View reviewed changes

ui/src/utils/plugins.js Outdated Show resolved Hide resolved

remove argument null

6274f9d

davidjumani approved these changes Jul 30, 2021

View reviewed changes

shwstppr approved these changes Jul 30, 2021

View reviewed changes

davidjumani merged commit 1ccd61c into apache:4.15 Jul 30, 2021

nvazquez mentioned this pull request Aug 6, 2021

Check and fix failing UI unit tests #5212

Closed

Conversation

utchoang commented Jul 20, 2021 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Types of changes

Feature/Enhancement Scale or Bug Severity

Feature/Enhancement Scale

Bug Severity

Screenshots (if appropriate):

How Has This Been Tested?

Uh oh!

utchoang commented Jul 26, 2021

Uh oh!

blueorangutan commented Jul 26, 2021

Uh oh!

blueorangutan commented Jul 26, 2021

Uh oh!

yadvr commented Jul 27, 2021

Uh oh!

weizhouapache left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

davidjumani commented Jul 29, 2021

Uh oh!

blueorangutan commented Jul 29, 2021

Uh oh!

blueorangutan commented Jul 29, 2021

Uh oh!

Uh oh!

utchoang commented Jul 29, 2021

Uh oh!

blueorangutan commented Jul 29, 2021

Uh oh!

blueorangutan commented Jul 29, 2021

Uh oh!

Uh oh!

davidjumani commented Jul 30, 2021

Uh oh!

blueorangutan commented Jul 30, 2021

Uh oh!

blueorangutan commented Jul 30, 2021

Uh oh!

davidjumani commented Jul 30, 2021

Uh oh!

davidjumani commented Jul 30, 2021

Uh oh!

yadvr commented Jul 30, 2021

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

utchoang commented Jul 20, 2021 •

edited

Loading